- 
                Notifications
    You must be signed in to change notification settings 
- Fork 123
[PE-7250] CoinDetailPage Tests + Integration test reorg #12820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job with the fixtures and asset-details test
…jd/coin-page-test-setup # Conflicts: # packages/web/src/components/notification/Notification/UserSubscriptionNotification.test.tsx # packages/web/src/pages/audio-page/WalletModal.tsx # packages/web/src/pages/coin-detail-page/AssetDetailPage.test.tsx # packages/web/src/pages/profile-page/ProfilePage.test.tsx
…jd/coin-page-test-setup
…jd/coin-page-test-setup # Conflicts: # packages/web/src/components/notification/Notification/UserSubscriptionNotification.test.tsx # packages/web/src/pages/coin-detail-page/components/CoinInfoSection.tsx # packages/web/src/pages/profile-page/ProfilePage.test.tsx
| // Removes the long DOM output from failed queries | ||
| configure({ | ||
| getElementError: (message: any) => new Error(message) | ||
| }) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the fence about whether to include this or not but the giant DOM it outputs is pretty useless most of the time since theres so much stuff on screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this drop the section that shows what accessible elements do exist on the page? that part is really useful, the big dom output after is not though
| @@ -0,0 +1,199 @@ | |||
| import { userMetadataFromSDK } from '@audius/common/adapters' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicee
| }, | ||
| test: { | ||
| environment: 'jsdom', | ||
| environment: 'happy-dom', | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! so main rationale here is render speed or what?
| ) | ||
| } | ||
|  | ||
| const assertCoinInsightsSection = async () => { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, liking these helper fns
Description
New tests
New test mock data patterns:
fixtures/folderhappy-dom, experimental for now. Supposed to be faster & lighterHow Has This Been Tested?
vitest